[patch, libbacktrace/libsanitizer/libquadmath/libcilkrts] fix multilib builds

Tobias Burnus tobias.burnus@physik.fu-berlin.de
Mon Jan 26 15:18:00 GMT 2015


Matthias Klose wrote:
> >> However for the libbacktrace and the libsanitizer builds, the AM_ENABLE_MULTILIB
> >> macro is included way too late.  Scan the generated configure file for
> >> "cross_compiling" and see that the above snippet is added after the failing
> >> checks. The fix seems to be simple, just move the AM_ENABLE_MULTILIB macro up so
> >> that the "cross_compiling" value is corrected before it is tested.  This is what
> >> the patch is doing.
[...]
> CCed, and there are more directories needing an update: libquadmath and
> libcilkrts.  Note that libcilkrts didn't have an AM_ENABLE_MULTILIB call at all,
> but nevertheless builds the multilib libraries.

> The attached patch just moves the AM_ENABLE_MULTILIB calls up in the files, so
> that these are found before GCC_NO_EXECUTABLES (which is not called in every
> libXXdir) and AC_PROC_CC.
> 
> x32 multilib enabled x86_64-linux-gnu and i686-linux-gnu configurations built
> successfully on a non-x32 enabled kernel.

>From my side, the libquadmath part of patch is okay.


Ian Lance Taylor wrote to the libbacktrace part of the patch:
> Probably a build maintainer should take a look at this patch.

I concur that that wouldn't harm.

Tobias



More information about the Gcc-patches mailing list