[[ARM/AArch64][testsuite] 36/36] Add vqdmull_n tests.

[Tejas Belagod]

On 13/01/15 15:18, Christophe Lyon wrote:
> 	* gcc.target/aarch64/advsimd-intrinsics/vqdmull_n.c: New file.
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqdmull_n.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqdmull_n.c
> new file mode 100644
> index 0000000..9e73009
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vqdmull_n.c
> @@ -0,0 +1,92 @@
> +#include <arm_neon.h>
> +#include "arm-neon-ref.h"
> +#include "compute-ref-data.h"
> +
> +/* Expected values of cumulative_saturation flag.  */
> +int VECT_VAR(expected_cumulative_sat,int,16,4) = 0;
> +int VECT_VAR(expected_cumulative_sat,int,32,2) = 0;
> +
> +/* Expected results.  */
> +VECT_VAR_DECL(expected,int,32,4) [] = { 0x44000, 0x44000,
> +					0x44000, 0x44000 };
> +VECT_VAR_DECL(expected,int,64,2) [] = { 0xaa000, 0xaa000 };
> +
> +/* Expected values of cumulative_saturation flag when saturation
> +   occurs.  */
> +int VECT_VAR(expected_cumulative_sat2,int,16,4) = 1;
> +int VECT_VAR(expected_cumulative_sat2,int,32,2) = 1;
> +
> +/* Expected results when saturation occurs.  */
> +VECT_VAR_DECL(expected2,int,32,4) [] = { 0x7fffffff, 0x7fffffff,
> +					 0x7fffffff, 0x7fffffff };
> +VECT_VAR_DECL(expected2,int,64,2) [] = { 0x7fffffffffffffff,
> +					 0x7fffffffffffffff };
> +
> +#define INSN_NAME vqdmull
> +#define TEST_MSG "VQDMULL_N"
> +
> +#define FNNAME1(NAME) exec_ ## NAME
> +#define FNNAME(NAME) FNNAME1(NAME)
> +
> +void FNNAME (INSN_NAME) (void)
> +{
> +  int i;
> +
> +  /* vector_res = vqdmull_n(vector,val), then store the result.  */
> +#define TEST_VQDMULL_N2(INSN, T1, T2, W, W2, N, L, EXPECTED_CUMULATIVE_SAT, CMT) \
> +  Set_Neon_Cumulative_Sat(0, VECT_VAR(vector_res, T1, W2, N));	\
> +  VECT_VAR(vector_res, T1, W2, N) =				\
> +    INSN##_n_##T2##W(VECT_VAR(vector, T1, W, N),		\
> +		     L);					\
> +  vst1q_##T2##W2(VECT_VAR(result, T1, W2, N),			\
> +		 VECT_VAR(vector_res, T1, W2, N));		\
> +  CHECK_CUMULATIVE_SAT(TEST_MSG, T1, W, N, EXPECTED_CUMULATIVE_SAT, CMT)
> +
> +  /* Two auxliary macros are necessary to expand INSN.  */
> +#define TEST_VQDMULL_N1(INSN, T1, T2, W, W2, N, L, EXPECTED_CUMULATIVE_SAT, CMT) \
> +  TEST_VQDMULL_N2(INSN, T1, T2, W, W2, N, L, EXPECTED_CUMULATIVE_SAT, CMT)
> +
> +#define TEST_VQDMULL_N(T1, T2, W, W2, N, L, EXPECTED_CUMULATIVE_SAT, CMT) \
> +  TEST_VQDMULL_N1(INSN_NAME, T1, T2, W, W2, N, L, EXPECTED_CUMULATIVE_SAT, CMT)
> +
> +  DECL_VARIABLE(vector, int, 16, 4);
> +  DECL_VARIABLE(vector, int, 32, 2);
> +  DECL_VARIABLE(vector2, int, 16, 4);
> +  DECL_VARIABLE(vector2, int, 32, 2);
> +
> +  DECL_VARIABLE(vector_res, int, 32, 4);
> +  DECL_VARIABLE(vector_res, int, 64, 2);
> +
> +  clean_results ();
> +
> +  /* Initialize vector.  */
> +  VDUP(vector, , int, s, 16, 4, 0x1000);
> +  VDUP(vector, , int, s, 32, 2, 0x1000);
> +
> +  /* Initialize vector2.  */
> +  VDUP(vector2, , int, s, 16, 4, 0x4);
> +  VDUP(vector2, , int, s, 32, 2, 0x2);
> +
> +  /* Choose multiplier arbitrarily.  */
> +  TEST_VQDMULL_N(int, s, 16, 32, 4, 0x22, expected_cumulative_sat, "");
> +  TEST_VQDMULL_N(int, s, 32, 64, 2, 0x55, expected_cumulative_sat, "");
> +
> +  CHECK(TEST_MSG, int, 32, 4, PRIx32, expected, "");
> +  CHECK(TEST_MSG, int, 64, 2, PRIx64, expected, "");
> +
> +  VDUP(vector, , int, s, 16, 4, 0x8000);
> +  VDUP(vector, , int, s, 32, 2, 0x80000000);
> +
> +#define TEST_MSG2 "with saturation"
> +  TEST_VQDMULL_N(int, s, 16, 32, 4, 0x8000, expected_cumulative_sat2, TEST_MSG2);
> +  TEST_VQDMULL_N(int, s, 32, 64, 2, 0x80000000, expected_cumulative_sat2, TEST_MSG2);
> +
> +  CHECK(TEST_MSG, int, 32, 4, PRIx32, expected2, TEST_MSG2);
> +  CHECK(TEST_MSG, int, 64, 2, PRIx64, expected2, TEST_MSG2);
> +}
> +
> +int main (void)
> +{
> +  FNNAME (INSN_NAME) ();
> +  return 0;
> +}
>

Patches 31 to 36 also LGTM.

A general nit about all the patches. Code like:

+  DECL_VARIABLE(vector, int, 16, 4);
+  DECL_VARIABLE(vector, int, 32, 2);
+  DECL_VARIABLE(vector2, int, 16, 4);
+  DECL_VARIABLE(vector2, int, 32, 2);
+  DECL_VARIABLE(vector_res, int, 32, 4);
+  DECL_VARIABLE(vector_res, int, 64, 2);

A space before the '(' is required.

Thanks for working on these tests.

Tejas.