[Ping] Port of VTV for Cygwin and MinGW

Caroline Tice cmtice@google.com
Mon Jan 12 18:32:00 GMT 2015


On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast
<patrick.wollgast@rub.de> wrote:
> A short recap again:
>
> Latest patch, changelog and a test program (further information about
> the program in the mail):
> https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html
>
>
> Approved:
> * gcc/config/i386/*
> * libgcc/*
> * libstdc++-v3/*
> * libvtv/*              (Some changes made to three of these files.
>                          Listed in 'Not approved'.)
>
>
> Not approved:
> For the following two files I added checks, if TARGET_PECOFF is defined
> ( https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html )
>         * gcc/cp/vtable-class-hierarchy.c
>         * gcc/varasm.c

The changes in gcc/cp/vtable-class-hierarchy.c and gcc/varasm.c both
look good to me.  However I am not authorized to approve stuff in this
part of GCC, so I need someone with global approval rights to look at
these changes and give the final OK.


>
> Reasons for changes in the following files stated in
> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html and in the mail
> of the latest patch.
>
> Removed implementation of mprotect.
>         * libvtv/vtv_malloc.cc
> Added extern "C" to the prototype of mprotect.
>         * libvtv/vtv_malloc.h
> Exchanged call to TerminateProcess with call to abort in __fortify_fail.
>         * libvtv/vtv_rts.cc

The changes in libvtv all look good to me (approved).

-- Caroline Tice
cmtice@google.com


>
> Has been removed from the most recent patch. Just listed for completeness.
>         * libiberty/obstack.c
>
>
> Regards,
> Patrick



More information about the Gcc-patches mailing list