[RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

Matthew Fortune Matthew.Fortune@imgtec.com
Fri Jan 9 12:27:00 GMT 2015


Robert Suchanek <Robert.Suchanek@imgtec.com> writes:

> gcc/
> 	* simplify-rtx.c (simplify_replace_fn_rtx): Simplify (lo_sum (high x)
> 	(const (plus x offset))) to (const (plus x offset)).

The fix appears valid to me. Just some comments on the test case.

> a/gcc/testsuite/gcc.target/mips/20150108.c
> b/gcc/testsuite/gcc.target/mips/20150108.c
> new file mode 100644
> index 0000000..f18dbe7
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/mips/20150108.c
> @@ -0,0 +1,25 @@
> +/* { dg-do compile } */
> +/* { dg-options "-mips32r2" } */

Please remove this line as there is nothing ISA dependent in the test case.

> +
> +long long a[10];
> +long long b, c, d, k, m, n, o, p, q, r, s, t, u, v, w; int e, f, g, h,
> +i, j, l, x;
> +

nit, no return type specified.

> +NOMIPS16 fn1() {

Nit, newline for the brace.

> +  for (; x; x++)
> +    if (x & 1)
> +      s = h | g;
> +    else
> +      s = f | e;
> +  l = ~0;
> +  m = 1 | k;
> +  n = i;
> +  o = j;
> +  p = f | e;
> +  q = h | g;
> +  w = d | c | a[1];
> +  t = c;
> +  v = b | c;
> +  u = v;
> +  r = b | a[4];
> +}
> --
> 1.7.9.5

Thanks,
Matthew


More information about the Gcc-patches mailing list