[PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C
Mike Stump
mikestump@comcast.net
Thu Jan 8 21:07:00 GMT 2015
On Jan 8, 2015, at 11:29 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> I disagree. Busy waiting of this kind is not appropriate for the test suite,
What busy waiting, there is none in the last version of the patch?
> tsan can't intercept the calls that you do through dlsym, because you
> explicitly bypass tsan in that case.
Ah, yes, right, I had pthread_barrier_wait on the brain, sorry. The direct use of it would be problematic. The dlopen use of it, is safe.
So, that removes the objection I had to his patch. Jakub, since he has a complete solution to the problem submitted with all the test cases fixed, I think it should go in.
Any objections to approving it now?
More information about the Gcc-patches
mailing list