[PATCH] Fix PR libstdc++/64422

Jonathan Wakely jwakely@redhat.com
Fri Jan 2 22:47:00 GMT 2015


On 02/01/15 19:59 +0000, Jonathan Wakely wrote:
>On 2 January 2015 at 18:05, Bernd Edlinger wrote:
>>
>> Hi,
>>
>> On Fri, 2 Jan 2015 16:41:38, Paolo Carlini wrote:
>>>
>>> Hi,
>>>
>>> On 01/02/2015 04:33 PM, Jonathan Wakely wrote:
>>>> The misc-inst.cc change looks good but as this is a libstdc++ bug the
>>>> testcase should be under the libstdc++-v3/testsuite dir and the patch
>>>> should be CC'd to the libstdc++ list.
>>> ... and shouldn't be a dg-do run, I would add.
>>>
>>> Paolo.
>>
>> How about this?  I verified that the test case is still able to detect
>> the missing symbols.
>> Actually I was not quite sure where to add the test case. Is it OK here?
>
>It isn't testing the member types, so I think either in
>21_strings/basic_string/ or 21_strings/basic_string/modifiers/ (since
>all the missing symbols happen to be ones defined in the "modifiers"
>subclause).
>
>For some reason that I don't really know, we put the FSF copyright and
>GPLv3+exception copying permission statement in all libstdc++ tests,
>please see one of the existing tests for the exact wording.
>
>OK for trunk after moving it to one of those other directories and
>adding the copyright boilerplate - thanks very much for fixing it.

One small tweak to the commit, the copyright date on the new file
should be just 2015. Committed to trunk.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150102/87275584/attachment.bin>


More information about the Gcc-patches mailing list