[Patch, Fortran, OOP] PR 57562: ICE due to extended derived type with PARAMETER attribute
Janus Weil
janus@gcc.gnu.org
Fri Jan 2 16:45:00 GMT 2015
Committed as r219144.
Cheers,
Janus
2015-01-02 17:13 GMT+01:00 Janus Weil <janus@gcc.gnu.org>:
> 2015-01-02 17:02 GMT+01:00 Tobias Burnus <burnus@net-b.de>:
>> + int ext = dt->attr.extension;
>> + while (ext>0 && gfc_find_component (dt->components->ts.u.derived,
>> pick->name,
>> + true, true))
>> + {
>> + dt = dt->components->ts.u.derived;
>> + c = gfc_constructor_first (c->expr->value.constructor);
>> + ext--;
>> + }
>>
>> Regtested on x86_64-unknown-linux-gnu. Ok for trunk?
>>
>>
>> Style comment: "ext>0" should be written as "ext > 0".
>
> Good point. Will fix.
>
>
>> Additionally, I'd prefer a test case which has another level of inheritance.
>> (Like the attached test case.)
>
> Sure, then I'll just use that one ...
>
>
>> Otherwise, it looks okay. Thanks!
>
> Thanks for the review!
>
> Cheers,
> Janus
More information about the Gcc-patches
mailing list