[PATCH] gcc/reload.c: Initialize several arrays before use them in find_reloads()

augustine.sterling@gmail.com augustine.sterling@gmail.com
Wed Feb 25 00:35:00 GMT 2015


On Tue, Feb 24, 2015 at 2:05 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Hi,
>
> On Tue, Feb 24, 2015 at 6:54 PM, Jeff Law <law@redhat.com> wrote:
>>
>> You can tackle them in any order you wish.  However, I suspect fixing the
>> xtensa backend may be easier.  I don't have any good way to test xtensa, but
>> something like the attached patch for the xtensa port should be sufficient.
>
> I can confirm that this patch fixes the issue. I haven't got a segfault
> as was reported in bugzilla, but I got some 'conditional jump or move
> depends on uninitialised value' under valgrind, originated from
> find_reloads, that the patch fixed. And with it the testcase from
> bugzilla actually produces code with loop instruction.

Max, the patch doesn't fix the underlying issue, it just hides the bad
memory reference by initializing what we were already accessing.

See Jeff Law's message earlier in the thread.



More information about the Gcc-patches mailing list