[PATCH][testsuite] Abort on failure in gcc.dg/pr30957-1.c

Tom de Vries Tom_deVries@mentor.com
Fri Feb 20 13:04:00 GMT 2015


On 20-02-15 10:42, Jakub Jelinek wrote:
> On Fri, Feb 20, 2015 at 10:25:54AM +0100, Tom de Vries wrote:
>> this patch reverses the abort logic in pr30957-1.c, such that it aborts on
>> failure rather than on success.
>
> That sounds really weird.  From the description it looks like it is a known bug
> that we don't return -0.0.
> If 0.0 is the right return value instead, I'd the test should be written as
> if (__builtin_copysignf (1.0, foo (0.0 / -5.0, 10)) != 1.0)
>    abort ();
> to make it clear you are expecting positive 0.
>

Updated patch accordingly. OK for stage1?

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-pr30957-1.c-pass-rather-xfail.patch
Type: text/x-patch
Size: 1842 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150220/20d23e7a/attachment.bin>


More information about the Gcc-patches mailing list