[PATCH] rtl-optimization/64935: Sorting of ready list is different with/without DEBUG_INSNs.
Maxim Kuvyrkov
maxim.kuvyrkov@linaro.org
Wed Feb 18 16:02:00 GMT 2015
Hi,
This patch fixes PR64935, which is triggered when ready list at the start of a basic block is greater than --param=max-sched-ready-insns. Sorting the ready list when it has more than max-sched-ready-insns elements is special in that we want to sort normal insns even if there are debug insns in the list. This is due to code for max-sched-ready-insns ignoring debug insns on purpose.
The problem in the bug can be fixed with a smallish patch (see https://gcc.gnu.org/bugzilla/attachment.cgi?id=34674), but it makes code look ugly and non-intuitive. The second version of the patch (the one attached here) is a bit bigger, but it gives functions definitive and clear purpose, and makes code easier to understand.
While reviewing the patch I suggest using context diff mode (in emacs C-c C-d). I couldn't convince git to generate context diff.
Bootstrapped/tested on x86_64-linux-gnu and cross-tested on arm-linux-gnueabihf. Markus also tested this patch on powerpc64-linux-gnu.
OK for trunk?
Thank you,
--
Maxim Kuvyrkov
www.linaro.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-PR64935.patch
Type: application/octet-stream
Size: 9697 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150218/8322f96e/attachment.obj>
More information about the Gcc-patches
mailing list