[PATCH] Fix testsuite race on additional_sources

Maxim Kuvyrkov maxim.kuvyrkov@linaro.org
Wed Feb 18 15:06:00 GMT 2015


Hi,

This testsuite patch fixes race on additional_source testsuite variable.  When a test has both dg-additional-sources and "dg-do run { target FOO }" directives, it may occur that the FOO test will attempt to use additional_sources, which will result in failure to compile FOO test.  It often happens that FOO test was done for one of the previous testcases (which didn't use dg-additional-sources), so the failure case is not stable.

This behavior can be more-or-less reliably triggered with

make check-gcc make RUNTESTFLAGS="i386.exp=gcc.target/i386/pr64291-1.c"

The attached patch fixes the problem.  OK for trunk and 4.9 branch?

Thanks,

--
Maxim Kuvyrkov
www.linaro.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-race-on-additional_sources.ChangeLog
Type: application/octet-stream
Size: 179 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150218/33c9b170/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-race-on-additional_sources.patch
Type: application/octet-stream
Size: 921 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150218/33c9b170/attachment-0001.obj>
-------------- next part --------------



More information about the Gcc-patches mailing list