[gomp4] libgomp updates

[Thomas Schwinge]

Hi!

On Thu, 18 Dec 2014 00:19:42 +0100, I wrote:
> On Wed, 17 Dec 2014 23:24:17 +0100, I wrote:
> > Committed to gomp-4_0-branch in r218839:
> > 
> > commit 1c4f05a68c6d0d5b6137bb6d85a293d16727b389
> > Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
> > Date:   Wed Dec 17 22:23:02 2014 +0000
> > 
> >     libgomp updates.

> >     	libgomp/

> >     	* libgomp-plugin.h: Rename GOMP_PLUGIN_notify to
> >     	GOMP_PLUGIN_debug.  Change all users.

> > --- libgomp/libgomp-plugin.c
> > +++ libgomp/libgomp-plugin.c

> >  void
> > +GOMP_PLUGIN_debug (int kind, const char *msg, ...)
> > +{
> > +  va_list ap;
> > +  
> > +  va_start (ap, msg);
> > +  gomp_debug (kind, msg, ap);
> > +  va_end (ap);
> > +}
> > +
> > +void
> >  GOMP_PLUGIN_error (const char *msg, ...)
> >  {
> >    va_list ap;
> > @@ -59,16 +71,6 @@ GOMP_PLUGIN_error (const char *msg, ...)
> >  }
> >  
> >  void
> > -GOMP_PLUGIN_notify (const char *msg, ...)
> > -{
> > -  va_list ap;
> > -  
> > -  va_start (ap, msg);
> > -  gomp_vnotify (msg, ap);
> > -  va_end (ap);
> > -}

Here, I introduced a bug, and please, nobody (!) ask me how long it took
to track down that one...  :'-( I hit this while debugging something: I
found that GOMP_PLUGIN_debug only worked "a little bit" (some arguments
did not get printed) -- I suspected (..., and tried to track down...)
strack corruption and what not, but not such a stupid typo in combination
with C's poor type system...  Committed to trunk in r220770:

commit 84551a30dc6b717eb8684578b0463e951270a5e8
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Feb 17 18:24:07 2015 +0000

    libgomp: Make GOMP_PLUGIN_debug actually work...
    
    	libgomp/
    	* libgomp-plugin.c (GOMP_PLUGIN_debug): Fix typo.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220770 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog        |    4 ++++
 libgomp/libgomp-plugin.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git libgomp/ChangeLog libgomp/ChangeLog
index 2c32d9e..8477c3b 100644
--- libgomp/ChangeLog
+++ libgomp/ChangeLog
@@ -1,4 +1,8 @@
 2015-02-17  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* libgomp-plugin.c (GOMP_PLUGIN_debug): Fix typo.
+
+2015-02-17  Thomas Schwinge  <thomas@codesourcery.com>
 	    Cesar Philippidis  <cesar@codesourcery.com>
 
 	* oacc-ptx.h (GOACC_INTERNAL_PTX): Add GOACC_tid, GOACC_ntid,
diff --git libgomp/libgomp-plugin.c libgomp/libgomp-plugin.c
index ffb22e9..f448ba9 100644
--- libgomp/libgomp-plugin.c
+++ libgomp/libgomp-plugin.c
@@ -55,7 +55,7 @@ GOMP_PLUGIN_debug (int kind, const char *msg, ...)
   va_list ap;
 
   va_start (ap, msg);
-  gomp_debug (kind, msg, ap);
+  gomp_vdebug (kind, msg, ap);
   va_end (ap);
 }
 


Grüße,
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150217/b7a9c45b/attachment.sig>