[Patch ARM] Improve guality tests - part 1 - pr36728-1.c
Jakub Jelinek
jakub@redhat.com
Wed Feb 4 11:41:00 GMT 2015
On Wed, Feb 04, 2015 at 11:33:19AM +0000, Ramana Radhakrishnan wrote:
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-1.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-1.c
> @@ -49,5 +49,6 @@ main ()
> int l = 0;
> asm ("" : "=r" (l) : "0" (l));
> a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : : "r" (l));
Please remove the space before "".
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-2.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-2.c
> @@ -49,5 +49,6 @@ main ()
> int l = 0;
> asm ("" : "=r" (l) : "0" (l));
> a = foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm ("" : : "r" (l));
Please add volatile, and remove the extra space in between : :
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-3.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-3.c
> @@ -47,5 +47,6 @@ main ()
> int l = 0;
> asm volatile ("" : "=r" (l) : "0" (l));
> foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : : "r" (l));
See the 1st comment.
> --- a/gcc/testsuite/gcc.dg/guality/pr36728-4.c
> +++ b/gcc/testsuite/gcc.dg/guality/pr36728-4.c
> @@ -47,5 +47,6 @@ main ()
> int l = 0;
> asm volatile ("" : "=r" (l) : "0" (l));
> foo (l + 1, l + 2, l + 3, l + 4, l + 5, l + 6, l + 30);
> + asm volatile ( "" : "r" (l));
Likewise. Also one : is missing, wonder how this could compile.
Jakub
More information about the Gcc-patches
mailing list