[RFC][PATCH] Fix broken handling of LABEL_REF in genrecog + genpreds.
Richard Sandiford
rdsandiford@googlemail.com
Fri Dec 18 09:56:00 GMT 2015
Dominik Vogt <vogt@linux.vnet.ibm.com> writes:
> The attached patch fixes the handling of LABEL_REF in genrecog and
> genpreds.
>
> The current code assumes that X can have only a mode than PRED (X,
> MODE) if X is CONST_INT, CONST_DOUBLE or CONST_WIDE_INT, but
> actually that can be also the case for a LABEL_REF with VOIDmode.
> Due to this it is necessary to add "const_int" (or similar) to
> match_code of some predicates handling label_ref but not
> const_int.
OK, thanks.
As mentioned in the other thread, I think LABEL_REFs shouldn't have
VOIDmode, so long-term we should be fixing the targets. I agree this
is the correct workaround until that happens though.
Richard
More information about the Gcc-patches
mailing list