[PATCH 4/7][ARM] Add ACLE feature macro for ARMv8.1 instructions.
Matthew Wahab
matthew.wahab@foss.arm.com
Tue Dec 15 16:03:00 GMT 2015
On 10/12/15 10:45, Ramana Radhakrishnan wrote:
> On Tue, Dec 8, 2015 at 7:45 AM, Christian Bruel <christian.bruel@st.com> wrote:
>> Hi Matthew,
>>>
>>> On 26/11/15 16:01, Matthew Wahab wrote:
>>>>
>>>> Hello,
>>>>
>>>> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the
>>>> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is
>>>> defined when the instructions are available, as it is when
>>>> -march=armv8.1-a is enabled with suitable fpu options.
>>>>
>>>> gcc/
>>>> 2015-11-26 Matthew Wahab <matthew.wahab@arm.com>
>>>>
>>>> * config/arm/arm-c.c (arm_cpu_builtins): Define
>>>> __ARM_FEATURE_QRDMX.
>>>>
>>>
>>
>> + if (TARGET_NEON_RDMA)
>> + builtin_define ("__ARM_FEATURE_QRDMX");
>> +
>>
>> Since it depends on TARGET_NEON, could you please use
>>
>> def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA);
>>
>> instead ?
>
> I think that's what it should be -
>
> OK with that fixed.
Attached an updated patch using the def_or_undef macro. It also removes some trailing
whitespace in that part of the code.
Still ok?
Matthew
gcc/
2015-12-14 Matthew Wahab <matthew.wahab@arm.com>
* config/arm/arm-c.c (arm_cpu_builtins): Define
__ARM_FEATURE_QRDMX. Clean up some trailing whitespace.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ARM-Add-__ARM_FEATURE_QRDMX.patch
Type: text/x-patch
Size: 1488 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20151215/8d91eaf1/attachment.bin>
More information about the Gcc-patches
mailing list