[PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

Jeff Law law@redhat.com
Fri Dec 11 21:06:00 GMT 2015


On 12/11/2015 01:13 PM, Jakub Jelinek wrote:
> On Fri, Dec 11, 2015 at 07:30:59AM +0100, Richard Biener wrote:
>>> So, to fix ICE on the following testcase, we can either do what the
>>> patch
>>> does, or could conditionalize both the calculate_dominance_info and
>>> free_dominance_info in the convert_scalars_to_vector function (stv
>>> pass)
>>> on the dominance info not being computed (like other places in gcc do),
>>> or we could stick free_dominance_info into all passes that break the
>>> dominators just in case it would be computed (out_of_cfglayout is one
>>> example).
>>
>> We rely on this everywhere else so that would be preferred.
>
> So like this instead?  Bootstrapped/regtested on x86_64-linux and
> i686-linux, ok for trunk?
>
> 2015-12-10  Jakub Jelinek  <jakub@redhat.com>
>
> 	PR rtl-optimization/68730
> 	* cfgrtl.c (cfg_layout_finalize): Free dominators.
>
> 	* gcc.dg/pr68730.c: New test.
OK.
jeff



More information about the Gcc-patches mailing list