[PATCH, ARM] PR68674 Fix LTO support for neon builtins and error catching

[Christian Bruel]

>> +  /* Check in the context of the function making the call whether the
>> +     builtin is supported.  */
>> +  if (fcode >= ARM_BUILTIN_NEON_BASE && !TARGET_NEON)
>> +    {
>> +      error ("%qE neon builtin is not supported in this configuration.",
>> +	     fndecl);
>> +      return const0_rtx;
>> +    }
>
> Can we make this error message more user friendly.
>
> "You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) to use these intrinsics"

yes, maybe also mention here arm_neon.h since this error is a sanity 
catch in case of direct __builtin calls.

what about something like:

"You must enable NEON instructions (e.g. -mfloat-abi=softfp -mfpu=neon) 
and use the functions from arm_neon.h"

?

thanks to the #pragma, calls from arm_neon.h should never result into 
this error (eventually a target specific option mismatch caught from 
arm_can_inline_p in case of mismatch with the caller)

>
>> +
>>     if (fcode >= ARM_BUILTIN_NEON_BASE)
>>       return arm_expand_neon_builtin (fcode, exp, target);
>>
>> +  if (fcode >= ARM_BUILTIN_CRYPTO_BASE
>> +      && (!TARGET_CRYPTO || !TARGET_HARD_FLOAT))
>> +    {
>> +      error ("%qE crypto builtin is not supported in this configuration.",
>> +	     fndecl);
>> +      return const0_rtx;
>> +    }
>
> "You must enable crypto intrinsics (e.g. -mfloat-abi=softfp -mfpu=crypto-neon...) to use these intrinsics"

yes, same as above

>
> I'm still playing with this patch.

thanks,

Regards

Christian

>
> regards
> Ramana
>
>
>
>
>