[Patch] Fix bug for frame instructions in annulled delay slots
Jeff Law
law@redhat.com
Mon Dec 7 19:30:00 GMT 2015
On 12/07/2015 12:28 PM, Bernd Schmidt wrote:
> On 12/07/2015 07:54 PM, Steve Ellcey wrote:
>> if (must_annul)
>> - used_annul = 1;
>> + {
>> + /* Frame related instructions cannot go into annulled delay
>> + slots, it messes up the dwarf info. */
>> + if (RTX_FRAME_RELATED_P (trial))
>> + return;
>
> Don't you need to use break rather than return?
>
>> + else if (!RTX_FRAME_RELATED_P (trial) \
>
> Stray backslash.
>
> Other than that I think this is OK. There are some preexisting tests for
> frame related insns already in this code.
Also note there's probably port cleanup that could happen once this goes
in. IIRC the PA port (for example) explicitly disallows frame related
insns from many (most, all?) delay slots. Other targets may be doing
something similar.
jeff
More information about the Gcc-patches
mailing list