[PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta

Tom de Vries Tom_deVries@mentor.com
Thu Dec 3 11:49:00 GMT 2015


On 30/11/15 14:32, Jakub Jelinek wrote:
> On Mon, Nov 30, 2015 at 02:24:18PM +0100, Richard Biener wrote:
>>> OK for stage3 trunk if bootstrap and reg-test succeeds?
>>
>> -                        || node->address_taken);
>> +                        || (node->address_taken
>> +                            && !node->parallelized_function));
>>
>> please add a comment here on why this is safe.
>>
>> Ok with this change.
>
> BTW, __builting_GOMP_task supposedly can be treated similarly
> if the third argument is NULL (if 3rd arg is non-NULL, then
> the caller passes a different structure from what the callee receives,
> but perhaps it could be emulated as pretending that cpyfn is called first
> with address of a temporary var and the data argument and then fn
> is called with the address of the temporary var).

Filed as PR68673 - Handle __builtin_GOMP_task optimally in ipa-pta.

Can you provide testcases for both (3rd arg NULL/non-NULL) cases? I'm 
not fluent in openmp.

Thanks,
- Tom



More information about the Gcc-patches mailing list