[Aarch64][target/PR 67143] Use correct constraints on operands for atomic operations.

James Greenhalgh james.greenhalgh@arm.com
Fri Aug 14 13:29:00 GMT 2015


On Thu, Aug 13, 2015 at 03:48:22PM +0100, Matthew Wahab wrote:
> On 12/08/15 22:26, Joseph Myers wrote:
> > On Tue, 11 Aug 2015, Matthew Wahab wrote:
> >
> >> 	PR target/67143
> >> 	* gcc.target/aarch64/pr67143.c: New
> >
> > What's architecture-specific about this test?  That is, why doesn't it
> > just go in gcc.c-torture/compile (no dg- directives needed, automatically
> > looped over optimization options)?
> >
> 
> Attached is an updated patch which puts the pr67143.c test case in
> gcc.c-torture/compile and drops the dg- directives.
> 
> Tested for aarch64-none-eabi with cross-compiled check-gcc. Also ran
> check-gcc for x86_64-none-linux-gnu, to check the new test case.
> 
> Ok?
> Matthew

OK, and please backport it to the 5.x (and 4.9.x if needed) branches.

Thanks,
James

> gcc/
> 2015-08-13  Matthew Wahab  <matthew.wahab@arm.com>
> 
> 	PR target/67143
> 	* config/aarch64/atomics.md (atomic_<optab><mode>): Replace
> 	'lconst_atomic' with 'const_atomic'.
> 	(atomic_fetch_<optab><mode>): Likewise.
> 	(atomic_<optab>_fetch<mode>): Likewise.
> 	* config/aarch64/iterators.md (lconst-atomic): Move below
> 	'const_atomic'.
> 	(const_atomic): New.
> 
> gcc/testsuite/
> 2015-08-13  Matthew Wahab  <matthew.wahab@arm.com>
> 	    Matthias Klose  <doko@debian.org>
> 
> 	PR target/67143
> 	* gcc.c-torture/compile/pr67143.c: New
> 	* gcc.target/aarch64/atomic-op-imm.c
> 	(atomic_fetch_add_negative_RELAXED): New.
> 	(atomic_fetch_sub_negative_ACQUIRE): New.
> 



More information about the Gcc-patches mailing list