[PATCH][MIPS] Fix register renaming in the interrupt handlers

Matthew Fortune Matthew.Fortune@imgtec.com
Thu Aug 13 11:26:00 GMT 2015


I'd like to give Catherine chance to review this, I notice a couple
of formatting nits in the test case:

Robert Suchanek <Robert.Suchanek@imgtec.com> writes:
> a/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> new file mode 100644
> index 0000000..877d00c
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
> @@ -0,0 +1,12 @@
> +/* { dg-options "-funroll-loops" } */
> +int foo;
> +int bar;
> +
> +void __attribute__ ((interrupt)) isr(void) {

Newline for function name and whitespace before args

> +  if (!foo)
> +   {

Double space indent for brace or remove them entirely as it is
single statement.

> +      while (bar & 0xFF30);
> +   }
> +}
> +/* { dg-final { scan-assembler-not "\\\$8" } } */

Thanks,
Matthew





More information about the Gcc-patches mailing list