[PATCH] warn for unsafe calls to __builtin_return_address

Jiong Wang jiong.wang@arm.com
Wed Aug 5 16:03:00 GMT 2015


On 28/07/15 16:44, Martin Sebor wrote:
>
> Attached is an updated patch with the changes above.
>

gcc/testsuite/ChangeLog
2015-07-28  Martin Sebor<msebor@redhat.com>

     * g++.dg/Wframe-address-in-Wall.C: New test.
     * g++.dg/Wframe-address.C: New test.
     * g++.dg/Wno-frame-address.C: New test.
     * gcc.dg/Wframe-address-in-Wall.c: New test.
     * gcc.dg/Wframe-address.c: New test.
     * gcc.dg/Wno-frame-address.c: New test.

noticed the new added "Wno-frame-address.c" fail on arm-none-linux-gnueabihf native test.

from the comments in the testcase:

+/* Verify that -Wframe-address is not enabled by default by enabling
+   -Werror and verifying the test still compiles.  */

seems you want to make sure -Wframe-address work correctly with -Werror, while for arm,
return_address hook is defined to only support level 0, NULL_RTX returned for all other levels,
so this caused Wno-frame-address.c failed in those tem != NULL check for builtin_return_address.

Regards,
Jiong



More information about the Gcc-patches mailing list