offload data version number

[Thomas Schwinge]

Hi!

Nathan's patch is waiting for trunk approval:

On Sat, 1 Aug 2015 20:06:39 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> On 07/31/15 12:10, Jakub Jelinek wrote:
> 
> > This will hopefully be just GOMP_4.1 instead in the end, but it can
> > change when gomp-4_1-branch is merged to trunk, we don't guarantee
> > ABI stability at this point.
> 
> Sure.
> 
> > I'd prefer version to go after devicep argument rather than before.
> Fixed.
> 
> > And really don't have ver_func vs. unver_func, just a single
> > callback that will take the version argument too (again, if possible
> > after target_id).
> 
> Fixed (& elsewhere).  The patch should be checked for intelmic if possible 
> (Ilya?).  The  changes there are very mechanical so I'm not expecting a problem.
> 
> We don't need to  make the initial value of GOMP_VERSION non-zero, because the 
> absence of the GOMP_OFFLOAD_version func will distinguish out of date plugins at 
> this point.
> 
> 
> >> +
> >> +  if (DLSYM_OPT (version, version))
> >
> > I'd prefer requiring version always (i.e. DLSYM (version);
> > plus the v != GOMP_VERSION checking).
> 
> Fixed.
> 
> ok?

I'd found one "infrastructure-class" problem in the libgomp intelmic
plugin build, which I addressed on gomp-4_0-branch in r226497,
<http://news.gmane.org/find-root.php?message_id=%3C878u9soc60.fsf%40kepler.schwinge.homeip.net%3E>,
patch again attached here, for easy reference (applies to trunk as-is):
0001-Fix-intelmic-libgomp-plugin-build.patch.

Then, for convenience, I'm also again attaching Nathan's patch:
trunk-version-4.patch.

Nathan, for the trunk commit, I suggest you simply merge my patch into
yours.


Grüße,
 Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-intelmic-libgomp-plugin-build.patch
Type: text/x-diff
Size: 7413 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150804/3701a2b3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: trunk-version-4.patch
Type: text/x-diff
Size: 22540 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150804/3701a2b3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150804/3701a2b3/attachment.sig>