[CHKP] Support returned bounds in thunks expand
Jeff Law
law@redhat.com
Thu Apr 2 19:42:00 GMT 2015
On 04/02/2015 08:49 AM, Ilya Enkovich wrote:
> Ping
>
> 2015-03-10 13:12 GMT+03:00 Ilya Enkovich <enkovich.gnu@gmail.com>:
>> Hi,
>>
>> Currentl we loose returned bounds when functions are merged. This patch fixes it by adding returne bounds support for cgraph_node::expand_thunk. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk?
>>
>> Thanks,
>> Ilya
>> --
>> gcc/
>>
>> 2015-03-06 Ilya Enkovich <ilya.enkovich@intel.com>
>>
>> * cgraphunit.c (cgraph_node::expand_thunk): Build returned
>> bounds for instrumented functions.
>>
>> gcc/testsuite/
>>
>> 2015-03-06 Ilya Enkovich <ilya.enkovich@intel.com>
>>
>> * gcc/testsuite/gcc.target/i386/thunk-retbnd.c: New.
I really dislike the amount of gimple and bounded pointer knowledge in
this code.
It seems like a significant modularity violation and while you didn't
introduce the gimple stuff, we probably shouldn't be making it worse.
Is it possible to let this code build up the thunk, then pass it off as
a whole to the chkp code to add the instrumentation, particularly for
the return value?
ALso, is this critical for stage4? It looks like this is strictly a
QofI change, correct?
jeff
More information about the Gcc-patches
mailing list