[COMMITTED][shrink-wrap] should not sink instructions which may cause trap ?

Jiong Wang jiong.wang@arm.com
Tue Sep 30 08:51:00 GMT 2014


On 30/09/14 05:26, Jeff Law wrote:
> On 09/29/14 12:06, Jiong Wang wrote:
>> thanks for pointing this out, patch updated.
>>
>> re-tested, pass x86-64 bootstrap and no regression on check-gcc/g++.
>> pass aarch64-none-elf cross check also.
>>
>> ok for trunk?
> Yes this is fine.

committed as 215709.

>
>> BTW, another bug exposed by linux x86-64 kernel build, and it's at
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63404
>>
>> the problem is caused by we missed clobber/use check. I will send
>> a seperate patch for review. really sorry for causing the trouble,
>> the insn move in generic code is actually not that generic, related
>> with some backend features...
> Noted.  These things happen, it's one of the things that makes working
> with RTL tough and one of the reasons we made a major focus away from
> RTL as the primary IL for optimization work.  But for things like
> shrink-wrapping, RTL is the right place to be.

thanks for the explanation. Now  I fell I get a deeper understanding of why it's
called RTL, the "Register Transfer Language" :)

>
> jeff
>
>




More information about the Gcc-patches mailing list