[PATCH i386 AVX512] [55/n] Extend `perm' insn patterns.

Uros Bizjak ubizjak@gmail.com
Wed Sep 24 16:35:00 GMT 2014


On Wed, Sep 24, 2014 at 2:53 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> Patch in the bottom extends `perm' insn
> patterns.
>
> Bootstrapped.
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
> Is it ok for trunk?
>
> gcc/
>         * config/i386/sse.md
>         (define_expand "<avx2_avx512f>_perm<mode>"): Rename to ...
>         (define_expand "<avx2_avx512bw>_perm<mode>"): this.

This is not consistent with the patch below. You are renaming to
<avx2_avx512>... Also, please use ellipsis before "this".
>         (define_expand "<avx512>_perm<mode>_mask"): Add 128/256-bit wide
>         version.

Mention also the rename, and "Use VI8F_256_512 mode iterator".

>         (define_insn "<avx2_avx512f>_perm<mode>_1<mask_name>"): Rename to ...
>         (define_insn "<avx2_avx512bw>_perm<mode>_1<mask_name>"): this.

Ellipsis before "this.

OK with updated ChangeLog.

Thanks,
Uros.



More information about the Gcc-patches mailing list