[PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

Jeff Law law@redhat.com
Mon Sep 22 17:51:00 GMT 2014


On 09/22/14 04:24, Jiong Wang wrote:
>> Great.  Can you send an updated patchkit for review.
>
> patch attached.
>
> please review, thanks.
>
> gcc/ * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the
> live-in of new created BB as the intersection of live-in from
> "old_dest" and live-out from "bb".
Looks good.  However, before committing we need a couple things.

1. Bootstrap & regression test this variant of the patch.  I know you 
tested an earlier one, but please test this one just to be sure.

2. Testcase.  I think you could test for either the reduction in the 
live-in set of the newly created block or that you're shrink wrapping 
one or more functions you didn't previously shrink-wrap.  I think it's 
fine if this test is target specific.

Jeff



More information about the Gcc-patches mailing list