[PR libfortran/62768] Handle filenames with embedded nulls

N.M. Maclaren nmm1@cam.ac.uk
Thu Sep 18 09:04:00 GMT 2014


On Sep 18 2014, Janne Blomqvist wrote:
>
>> Apparently libgfortran is not compiled with -Werror, at least
>> not for crosses.  Maybe -Werror is there for native but I'm not
>> sure as I see some "warning: array subscript has type 'char'
>> [-Wchar-subscripts]" which seems generic and also some others.
>> Though no more than can be fixed or excepted, IMHO.
>
>No, Werror isn't used. It was tried, but apparently caused issues.
>From the changelog:
>
>2008-06-13  Tobias Burnus  <burnus@net-b.de>
>
>        * configure.ac (AM_CFLAGS): Remove -Werror again.
>
>I have a vague recollection that there were issues with system headers
>on non-glibc targets. It would be nice if Werror was used by default,
>I think we've had a few cases where bugs have slipped past due to it.

I wasn't involved, but that sounds more than just likely!  I have had
that experience with several options, including Werror, pedantic and
specific standards ones.  My experience is that most vendors clean up
at least the standard C headers with time, and usually the more basic
POSIX ones, but any others often remain beyond redemption.

And what is not going to help is the ongoing incompatibilities
in de jure and de facto standards.  I have certainly seen standard
headers that would compile only with specific language selection
options.  Oh, yes, their COMPILER supported other ones - you just
couldn't use some important system headers with them :-(

If I get time, I will look at the libfortran header use and see if I
can make any useful specific comments.


Regards,
Nick Maclaren.



More information about the Gcc-patches mailing list