[ping*3] fix build failure of x86_64-mingw32, missing crtbegin/crtend.o

Kai Tietz ktietz70@googlemail.com
Wed Sep 17 10:55:00 GMT 2014


2014-09-17 12:38 GMT+02:00 Olivier Hainque <hainque@adacore.com>:
> Hello Kai,
>
> On Sep 17, 2014, at 10:52 , Kai Tietz <ktietz70@googlemail.com> wrote:
>
>> Sorry for the delay in review.
>
>  No problem at all. Thanks for your feedback :)
>
>>  Patch looks ok.  Have you just tested
>> -pc- variant, or also -w64- one?
>
>  Just the -pc- variant, by our nightly builders.
>
>  We probably could twist our configuration scripts to experiment the -w64-
>  variant as well.  Might take a bit of time though.

Well, would be interesting.  As you are using for 64-bit anyway
mingw-w64's runtime, it doesn't make here any difference AFAICS.  The
-pc- vs. the -w64- varaint just controls the enabling of some
additional features.  So said, -pc- is legacy version.

>  AFAICS, the w64 variant resorts to the crtstuff objects as well and there's
>  no special case for -w64 in libgcc/config.host, so it really looks like the
>  change is needed for this variant also.
>
>  Regards,
>
>  Olivier

So, patch is ok. Please apply patch to trunk.

Kai



More information about the Gcc-patches mailing list