[match-and-simplify] CSE with expression captures

[Richard Biener]

On Tue, Sep 16, 2014 at 8:25 AM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> On Tue, Sep 16, 2014 at 2:15 AM, Marc Glisse <marc.glisse@inria.fr> wrote:
>> On Tue, 16 Sep 2014, Prathamesh Kulkarni wrote:
>>
>>> --- gcc/match-builtin.pd        (revision 215271)
>>> +++ gcc/match-builtin.pd        (working copy)
>>> @@ -44,8 +44,8 @@
>>>           /* ???  There is no way to CSE here.  We'd need to support
>>>              expression captures here, like with
>>>               (mult (realpart@1 @0) @1) */
>>> -         (mult (realpart @0) (realpart @0))
>>> -         (mult (imagpart @0) (imagpart @0)))))))
>>> +         (mult (realpart@1 @0) @1) +     (mult (imagpart@2 @0) @2))))))
>>
>>
>> Maybe remove the comment above?
>>
>> You seem to have trailing spaces on most of your new lines.
> Thanks, fixed.
>
> * genmatch.c (operand::gen_transform): Add dt_operand ** default argument
> to operand heirarchy.
>   (expr::gen_transform): Adjust.
>   (capture::gen_transform): Likewise.
>   (dt_simplify::gen): Likewise.
>
> * match-builtins.pd: Adjust pattern to use expression captures in
> transform.

Heh, that was simpler than I thought ;)

Thanks, applied.

Richard.

> Regards,
> Prathamesh
>>
>> --
>> Marc Glisse