Fix pr61848, linux kernel miscompile

Alan Modra amodra@gmail.com
Tue Sep 16 06:03:00 GMT 2014


On Mon, Sep 15, 2014 at 08:36:58PM +0000, Joseph S. Myers wrote:
> On Mon, 15 Sep 2014, Alan Modra wrote:
> 
> > This patch cures the linux kernel boot failure when compiled using
> > trunk gcc.  (Andrew, apologies for hijacking your bugzilla, I started
> > work on this before finding the bugzilla..)
> 
> Please include testcases in your patch for each case that you fix.

gcc testsuite additions?  I decline.  It is too soon.  If you had read
my patch submission you'll see that at some stage gcc was supposed to
warn on conflicting section attributes, but hasn't done so for a very
long time.  There needs to be some agreement on which direction we
should go before I'm willing to spend even a small amount of time on
the testsuite.  Also, a test for merging tls model attributes runs
into the problem that this can only be done in a target independent
way by looking at dumps, and the tls model dump is currently broken.

Come to think of it, what if I decline to make any testsuite
additions?  I'm asking because you're a steering committee member, and
set policy.  I fully agree that testsuite additions are desirable,
but, is *requiring* such testsuite additions a good idea?  Will that
really improve gcc over time?  (Herding cats comes to mind.  I think
you'll just drive away gcc contributors.)

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Gcc-patches mailing list