[PATCH 2/2] add static typed insn_deleted_p

Yury Gribov y.gribov@samsung.com
Mon Sep 15 10:12:00 GMT 2014


On 09/12/2014 05:17 AM, Trevor Saunders wrote:
> On Thu, Sep 11, 2014 at 08:06:02PM -0400, David Malcolm wrote:
>> FWIW, in case it's helpful, I have a script here that I use to help make
>> ChangeLog entries:
>> https://github.com/davidmalcolm/gcc-refactoring-scripts/blob/master/generate-changelog.py
>> (needs to be able to import the sibling "refactor" module)
>>
>> You feed it a git diff, and it generates a fragment of ChangeLog,
>> grouped according to subdirectory appropriately (based on which have
>> ChangeLog files), with each hunk indented so you can see what changed,
>> and write stuff accordingly (the assumption being that any automated
>> approach is going to get things wrong, and that human review is
>> necessary).
>
> yeah, I tend to use contrib/mklog except in cases like this where I'm
> going to give the same comment for a bunch of files.  In that case I use
> something like git diff --stat | sed and then handle the few single
> items manually, but it turns out the problem with humans is they make
> mistakes.
>
> btw it would be great to merge your thing with mklog somehow ideally
> resulting in less perl ;-)

Rewriting mklog in Python has been discussed a dozen of times (it's not 
that I like Python). Note that this would probably require significant 
testing (I can share my mklog testsuite). E.g. current 
generate-changelog.py does not seem to handle context diffs.

-Y



More information about the Gcc-patches mailing list