Build breakage on darwin and pa64-hpux [was Re: Use -fbuilding-libgcc for more target macros used in libgcc]

Joseph S. Myers joseph@codesourcery.com
Mon Sep 8 23:54:00 GMT 2014


On Sat, 6 Sep 2014, Andreas Schwab wrote:

> Mike Stump <mikestump@comcast.net> writes:
> 
> > Index: config/pa/pa64-hpux.h
> > ===================================================================
> > --- config/pa/pa64-hpux.h	(revision 214981)
> > +++ config/pa/pa64-hpux.h	(working copy)
> > @@ -336,7 +336,7 @@ do {								\
> >     the sections are not actually used.  However, we still must provide
> >     defines to select the proper code path.  */
> >  #undef INIT_SECTION_ASM_OP
> > -#define INIT_SECTION_ASM_OP
> > +#define INIT_SECTION_ASM_OP ""
> >  #undef FINI_SECTION_ASM_OP
> >  #define FINI_SECTION_ASM_OP
> 
> What about FINI_SECTION_ASM_OP?

My patch didn't do anything with FINI_SECTION_ASM_OP.

As it's not actually used on the host at all (unlike INIT_SECTION_ASM_OP), 
it could be moved to libgcc_tm.h.  However, my inclination is that it 
would be confusing to have such closely related target macros in different 
places, and so it would make sense to add FINI_SECTION_ASM_OP and 
FINI_ARRAY_SECTION_ASM_OP to the target macros that are communicated to 
libgcc via macros predefined with -fbuilding-libgcc.  (This is without 
prejudice to any possible future cleanup or refactoring of the macros in 
this area.)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Gcc-patches mailing list