[PINGv4][PATCHv3] Fix vector tests on ARM platforms with disabled unaligned accesses

Marat Zakirov m.zakirov@samsung.com
Fri Sep 5 13:06:00 GMT 2014


On 09/04/2014 09:23 PM, Mike Stump wrote:
> On Sep 4, 2014, at 4:14 AM, Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote:
>>> --- a/gcc/testsuite/lib/target-supports.exp
>>> +++ b/gcc/testsuite/lib/target-supports.exp
>>> @@ -2293,8 +2293,8 @@ proc check_effective_target_arm_little_endian { } {
>>> proc check_effective_target_arm_vect_no_misalign { } {
>>>      return [check_no_compiler_messages arm_vect_no_misalign assembly {
>>>         #if !defined(__arm__) \
>>> -           || (defined(__ARMEL__) \
>>> -               && (!defined(__thumb__) || defined(__thumb2__)))
>>> +           || (defined(__ARM_FEATURE_UNALIGNED) \
>>> +               && defined(__ARMEL__))
>>>         #error FOO
>>>         #endif
>>>      }]
>>>
>> Ok by me. But please wait for a testsuite maintainer to approve.
> Ok.
>
> Generally the port people that have been around for a while know what strikes them as wrong or not and can just approve the patch directly.  I suspect you are one of those people.  :-)  If you have any doubts or concerns, you can always raise them or ask for some help reviewing.  DonÂ’t worry, if I spot something I donÂ’t like after someone else says Ok, I will bring up the issue for consideration.  Even if I do, it doesnÂ’t mean I object in anyway to the first review.

Thank you all.

Committed revision 214956.

--Marat

-------------- next part --------------
A non-text attachment was scrubbed...
Name: unalign3.diff
Type: text/x-patch
Size: 2661 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140905/d7f2e25a/attachment.bin>


More information about the Gcc-patches mailing list