[PATCH PR62151]Fix uninitialized register issue caused by distribute_notes in combine pass

Segher Boessenkool segher@kernel.crashing.org
Mon Sep 1 11:39:00 GMT 2014


On Mon, Sep 01, 2014 at 11:36:07AM +0800, Bin.Cheng wrote:
> > In the testcase (and comment in the proposed patch), why is combine
> > combining four insns at all?  That means it rejected combining just the
> > first three.  Why did it do that?
> It is explicitly reject by below code in can_combine_p.
> 
>   if (GET_CODE (PATTERN (i3)) == PARALLEL)
>     for (i = XVECLEN (PATTERN (i3), 0) - 1; i >= 0; i--)
>       if (GET_CODE (XVECEXP (PATTERN (i3), 0, i)) == CLOBBER)
>     {
>       /* Don't substitute for a register intended as a clobberable
>          operand.  */
>       rtx reg = XEXP (XVECEXP (PATTERN (i3), 0, i), 0);
>       if (rtx_equal_p (reg, dest))
>         return 0;
> 
> Since insn i2 in the list of i0/i1/i2 as below contains parallel
> clobber of dest_of_insn76/use_of_insn77.
>    32: r84:SI=0
>    76: flags:CC=cmp(r84:SI,0x1)
>       REG_DEAD r84:SI
>    77: {r84:SI=-ltu(flags:CC,0);clobber flags:CC;}
>       REG_DEAD flags:CC
>       REG_UNUSED flags:CC

Archaeology suggests this check is because the clobber might be an
earlyclobber.  Which seems silly: how can it be a valid insn at all
in that case?  It seems to me the check can just be removed.  That
will hide your issue, maybe even solve it (but I doubt it).

If not, then combining the four insns (your case that explodes)
should not be allowed either (it's just the same, with a register
copy tucked on the end).  I haven't looked, but a missing can_combine_p
call perhaps?

Another question is why is r84 set twice in the first place?


Segher



More information about the Gcc-patches mailing list