[PATCH i386 AVX512] [86/n] Add tests for options.

Uros Bizjak ubizjak@gmail.com
Thu Oct 23 18:39:00 GMT 2014


On Wed, Oct 22, 2014 at 2:37 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> This patch extends sse-* and avx-* tests
> which checks immediates/options.
>
> Bootstrapped.
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
> Is it ok for trunk?
>
> gcc/
>         * testsuite/g++.dg/other/i386-2.C: Add new options.
>         * testsuite/g++.dg/other/i386-3.C: Ditto.
>         * testsuite/gcc.target/i386/sse-12.c: Ditto.
>         * testsuite/gcc.target/i386/sse-14.c: Ditto.
>         * testsuite/gcc.target/i386/sse-22.c: Ditto.
>         * testsuite/gcc.target/i386/sse-13.c: Add new options and builtins.
>         * testsuite/gcc.target/i386/sse-23.c: Ditto.
>         * testsuite/gcc.target/i386/avx-1.c: Add new builtins.
>

OK with TODOs resolved.

>  /* shaintrin.h */
>  #define __builtin_ia32_sha1rnds4(A, B, C) __builtin_ia32_sha1rnds4(A, B, 1)
>
> +/* TODO split */

I don't like TODOs in a submitted patch without the reason.

>  /* shaintrin.h */
>  #define __builtin_ia32_sha1rnds4(A, B, C) __builtin_ia32_sha1rnds4(A, B, 1)
> +
> +/* TODO split later */

"Later" has come ;)

Uros.



More information about the Gcc-patches mailing list