[PATCH] AutoFDO patch for trunk

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Wed Oct 22 15:26:00 GMT 2014


Dehao Chen <dehao@google.com> writes:

> The updated patch attached. Will commit the patch in 2~3 hours if no
> objection is received.

Apart from the AIX bootstrap failure your patch introduced, it also
breaks Solaris bootstrap:

In file included from ./config.h:6:0,
                 from /vol/gcc/src/hg/trunk/local/gcc/auto-profile.c:25:
./auto-host.h:1976:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
 #define _FILE_OFFSET_BITS 64
 ^
In file included from /usr/include/iso/string_iso.h:24:0,
                 from /usr/include/string.h:11,
                 from /vol/gcc/src/hg/trunk/local/gcc/auto-profile.c:21:
/var/gcc/regression/trunk/11-gcc/build/prev-gcc/include-fixed/sys/feature_tests.h:213:0: note: this is the location of the previous definition
 #define _FILE_OFFSET_BITS 32
 ^

As Joseph is repeating over and over again, *nothing* must be included
before config.h, and auto-profile.c violates this.

The following patch at least allows the file to compile without errors;
no idea if this the best order for the headers involved.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ap.patch
Type: text/x-patch
Size: 463 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20141022/547d30c6/attachment.bin>
-------------- next part --------------

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


More information about the Gcc-patches mailing list