[PATCH, ARM] attribute target (thumb,arm) [0/6]
Christian Bruel
christian.bruel@st.com
Fri Nov 28 09:20:00 GMT 2014
Hi Ramana,
On 11/27/2014 11:36 AM, Ramana Radhakrishnan wrote:
> On Wed, Nov 19, 2014 at 2:54 PM, Christian Bruel <christian.bruel@st.com> wrote:
>>
>>
>> On 11/19/2014 03:18 PM, Ramana Radhakrishnan wrote:
>>>
>>> On Wed, Nov 19, 2014 at 1:24 PM, Christian Bruel <christian.bruel@st.com>
>>> wrote:
>>>
>>>> I think I missed the stage3, Anyway would it be OK for stage1 when it
>>>> reopens ?
>>>
>>>
>>> Since you submitted this well during stage1 and given that these
>>> patches address comments from earlier in the review process we should
>>> aim to get these in for 5.0. If at some point during the review
>>> process it looks risky and there needs to be significant rework we can
>>> always stop. It's on the list of patches to be reviewed and I will
>>> find some dedicated time later this week to set down and review / play
>>> with the patches in an attempt to move this forward as it is a
>>> reasonably large chunk of work.
>>
>>
>> Thanks, also I forgot to mention that you need
>> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01231.html
>> to play with the attribute. Will be part of the same shot.
>
> Isn't that Ok'd for committing ? Why then isn't it applied ?
yes it was, it is in my single changeset with the attribute target since
itÅ the only way to trigger the issue.
Cheers
Christian
>
> Ramana
>
>>
>> Christian
>>
>>
>>>
>>> Thanks for continuing to work on these patches and addressing the
>>> earlier review comments.
>>>
>>> regards
>>> Ramana
>>>
>>>>
>>>> Christian
>>>>
>>
More information about the Gcc-patches
mailing list