[PATCH] Fix a bug in bt-load.c

Segher Boessenkool segher@kernel.crashing.org
Tue Nov 25 18:17:00 GMT 2014


On Tue, Nov 25, 2014 at 09:41:40AM -0700, Jeff Law wrote:
> On 11/24/14 20:56, Segher Boessenkool wrote:
> >This caused ICEs on sh64.
> >
> >`min_cost' and `def' here are supposed to refer to the same element;
> >removing it from the heap before asking the heap for the key doesn't
> >work (and at the end of the loop here we will ask for min_key on an
> >empty heap, which then does gcc_unreachable).

> Did sh64 ICE during a build, or was it during testing or something else? 
>  Trying to figure out if we need a distinct test in the suite or not.

During libgcc build, pretty much all files.

The libiberty fibheap code returns 0 for min_key on an empty heap; the
new fibonacci_heap code ICEs.  This bt-load code will always fail if
there is any work to do, so I don't think any other test is needed :-)


Segher



More information about the Gcc-patches mailing list