[PATCH] PR ipa/63909 ICE: SIGSEGV in ipa_icf_gimple::func_checker::compare_bb()

[Richard Biener]

On Thu, Nov 20, 2014 at 5:30 PM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> Following patch fixes ICE in IPA ICF. Problem was that number of non-debug
> statements in a BB can
> change (for instance by IPA split), so that the number is recomputed.

Huh, so can it get different for both candidates?  I think the stmt compare
loop should be terminated on gsi_end_p of either iterator and return
false for any remaining non-debug-stmts on the other.

Thus, not walk all stmts twice here.

As IPA split is run early I don't see how it should affect a real IPA
pass though?

Thanks,
Richard.

> Patch can bootstrap on x86_64-linux-pc and no regression has been seen.
> Ready for trunk?
>
> Thanks,
> Martin