[Patch ARM Refactor Builtins 3/8] Pull builtins code to its own file

Ramana Radhakrishnan ramana.radhakrishnan@arm.com
Tue Nov 18 09:17:00 GMT 2014



On 12/11/14 17:10, James Greenhalgh wrote:
>
> Hi,
>
> The config/arm/arm.c file has always seemed a worrying size to me.
>
> This patch pulls out the builtin related code to its own file. I think
> this will be a good idea as we move forward. It seems a more sensible
> separation of concerns. There are no functional changes here.
>
> Bootstrapped and regression tested on arm-none-linux-gnueabi, with
> no issues.
>
> OK?
>
> Thanks,
> James
>
> ---
> 2014-11-12  James Greenhalgh  <james.greenhalgh@arm.com>
>
> 	* config.gcc (extra_objs): Add arm-builtins.o for arm*-*-*.
> 	(target_gtfiles): Add config/arm/arm-builtins.c for arm*-*-*.
> 	* config/arm/arm-builtins.c: New.
> 	* config/arm/t-arm (arm_builtins.o): New.
> 	* config/arm/arm-protos.h (arm_expand_builtin): New.
> 	(arm_builtin_decl): Likewise.
> 	(arm_init_builtins): Likewise.
> 	(arm_atomic_assign_expand_fenv): Likewise.
> 	* config/arm/arm.c (arm_atomic_assign_expand_fenv): Remove prototype.
> 	(arm_init_builtins): Likewise.
> 	(arm_init_iwmmxt_builtins): Likewise
> 	(safe_vector_operand): Likewise
> 	(arm_expand_binop_builtin): Likewise
> 	(arm_expand_unop_builtin): Likewise
> 	(arm_expand_builtin): Likewise
> 	(arm_builtin_decl): Likewise
> 	(insn_flags): Remove static.
> 	(tune_flags): Likewise.
> 	(enum arm_builtins): Move to config/arm/arm-builtins.c.
> 	(arm_init_neon_builtins): Likewise.
> 	(struct builtin_description): Likewise.
> 	(arm_init_iwmmxt_builtins): Likewise.
> 	(arm_init_fp16_builtins): Likewise.
> 	(arm_init_crc32_builtins): Likewise.
> 	(arm_init_builtins): Likewise.
> 	(arm_builtin_decl): Likewise.
> 	(safe_vector_operand): Likewise.
> 	(arm_expand_ternop_builtin): Likewise.
> 	(arm_expand_binop_builtin): Likewise.
> 	(arm_expand_unop_builtin): Likewise.
> 	(neon_dereference_pointer): Likewise.
> 	(arm_expand_neon_args): Likewise.
> 	(arm_expand_neon_builtin): Likewise.
> 	(neon_split_vcombine): Likewise.
> 	(arm_expand_builtin): Likewise.
> 	(arm_builtin_vectorized_function): Likewise.
> 	(arm_atomic_assign_expand_fenv): Likewise.
>

Ok.

Ramana



More information about the Gcc-patches mailing list