Concepts code review

[Jason Merrill]

On 11/15/2014 07:58 PM, Braden Obrzut wrote:
> Variable templates (and thus concepts) are TEMPLATE_ID_EXPR.  I changed
> the comment to explicitly state that it will be a TEMPLATE_ID_EXPR, but
> I'm not sure the name needs to be changed.  If I recall correctly, I
> initially implemented as *_var_concept and Andrew told me to shorten
> it.  Note that this also matches up with normalize_var.

OK.

>> I think if the caller is calling finish_scope, I'd prefer for the
>> begin_scope call to be there as well.
>>
> Even though Andrew said that this will change later for other reasons,
> it's a function I wrote so: I actually debated this with Andrew before.
> My rationale for calling begin_scope in the function was that it feels
> consistent with the semantics of the call. Specifically it can be seen
> as reopening the function parameter scope.  Thus the call is balanced by
> calling finish_scope.  Either way would work of course, but perhaps it
> just needed a better name and/or comment?

A better name would be OK.  Perhaps push_function_parms_with_scope.

Jason