[PATCH 7/8] Model cache auto-prefetcher in scheduler

Maxim Kuvyrkov maxim.kuvyrkov@linaro.org
Fri Nov 14 15:10:00 GMT 2014


On Nov 14, 2014, at 4:57 AM, Vladimir Makarov <vmakarov@redhat.com> wrote:

> On 2014-10-21 12:06 AM, Maxim Kuvyrkov wrote:
> 
...
> I'd prefer symbolic constants for dont_delay.  Also the address can contains other parts, e.g. index for some targets.  It is not necessary to change the code but a comment would be nice that right now it is oriented for machine with base+disp only addressing.
> 
> Although it is probably matter of taste.  So you are free to commit it without any change.

I'll add an enum with symbolic constants for dont_delay and a comment about handled memory address types.

Thanks for the review!

--
Maxim Kuvyrkov
www.linaro.org



More information about the Gcc-patches mailing list