system.h vs. C++ STL headers again

Jakub Jelinek jakub@redhat.com
Fri Nov 14 11:55:00 GMT 2014


On Fri, Nov 14, 2014 at 12:27:52PM +0100, Bernd Schmidt wrote:
> On 11/14/2014 12:03 PM, Jakub Jelinek wrote:
> >On Fri, Nov 14, 2014 at 11:57:57AM +0100, Richard Biener wrote:
> >>>?  There are also some comments about stdarg.h and stdio.h ordering,
> >>>dunno what it comes from and if it is still relevant when we require
> >>>C++ compiler.
> >>
> >>I think we should simply discourage people from using sstream for
> >>example.
> >
> >That would be my preference too of course, unfortunately Bernd chose to use
> >it everywhere (grep '<<' nvptx.c').
> 
> I needed a way to output something but defer it to the end of the assembly
> file. sstream seemed like the tool for the job; if we go to the trouble of
> converting the compiler to C++ we might as well use the language as
> intended.
> 
> FWIW Cesar also ran into this problem and moving the sstream include first
> seems to solve it, so I'll be committing that fix.

Please include it after config.h though.

	Jakub



More information about the Gcc-patches mailing list