[PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C (try 2)

Manuel López-Ibáñez lopezibanez@gmail.com
Tue Nov 11 23:10:00 GMT 2014


On 11 November 2014 17:10, Jason Merrill <jason@redhat.com> wrote:
> On 10/31/2014 10:01 PM, Manuel López-Ibáñez wrote:
>>
>> +        sense.  So let's live the location intact in that case.  */
>
>
> s/live/leave/
>
>> +  /* If MAP is not the last line map of its set, then the new location
>> +     (loc + offset) should be less than the first location encoded by
>> +     the next line map of the set.  */
>
>
>> +    linemap_assert (MAP_START_LOCATION (&map[1]) < loc + offset);
>
>
> This comparison looks backwards from the comment.

Copy-paste error. In any case, this check is currently pointless,
since Fortran only has one map per set. I fixed this and tested
Fortran again just in case. No failures, thus I committed the whole
thing as http://gcc.gnu.org/r217383.

Cheers,

Manuel.



More information about the Gcc-patches mailing list