[PATCH] Support asan-instrumentation-with-call-threshold in GCC
Yury Gribov
y.gribov@samsung.com
Mon May 26 16:31:00 GMT 2014
>> * asan_negative_params_1.diff - support for negative parameters
>
> I don't like this. Why do you need it?
That's only for compatibility with LLVM. I know that's not usually
considered an argument in gcc-patches but things like this would surely
make developer's life harder.
>> * asan_calls_1.diff - the proper
>
> Note, the patch conflicts with the recently posted asan patches,
> please wait until those are reviewed.
Right, thanks for heads up.
>> +static int asan_num_accesses;
>
> I don't see this variable ever changed, so don't see
> how the patch can actually work.
True, I haven't run into this because test runs with -1 threshold (and
this does work).
Other points noted.
-Y
More information about the Gcc-patches
mailing list