Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

[Mark Wielaard]

On Wed, 2014-05-21 at 10:33 -0400, Jason Merrill wrote:
> On 05/21/2014 09:27 AM, Mark Wielaard wrote:
> > +/* The C++ version of the enum_underlying_base_type langhook.
> > +   See also cp/semantics.c (finish_underlying_type).  */
> > +static tree cxx_enum_underlying_base_type (const_tree type)
> 
> We usually leave a blank line between the comment and the function. 
> Also, the function name should be at the beginning of the line for etags.

Fixed both issues.

> > +/* Default implementation of enum_underlying_base_type using type_for_size.  */
> > +tree
> > +lhd_enum_underlying_base_type (const_tree enum_type)
> 
> Blank line here, too.

Added.

> >    tree (*reconstruct_complex_type) (tree, tree);
> > +
> > +  tree (*enum_underlying_base_type) (const_tree);
> 
> And please add a comment documenting the hook.

Documentation added.

> OK with those changes.

Pushed as attached.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PR-debug-16063.-Add-DW_AT_type-to-DW_TAG_enumeration.patch
Type: text/x-patch
Size: 7895 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140521/869f9a18/attachment.bin>