RFA: Fix calculation of size of builtin setjmp buffer

Nicholas Clifton nickc@redhat.com
Wed May 14 13:32:00 GMT 2014


Hi Eric,

>> 2014-05-06  Nick Clifton  <nickc@redhat.com>
>>
>> 	* except.c (init_eh): Fix computation of builtin setjmp buffer
>> 	size.
>
> That's the same patch as
>    https://gcc.gnu.org/ml/gcc-patches/2011-11/msg00272.html
> and is still incorrect.

Ah - you are worried about the case where STACK_SAVEAREA_MODE() is 
smaller than Pmode, yes ?

OK then, how about this revised version of the patch where the size 
computation is now:

      tmp = size_int (MAX (GET_MODE_SIZE (STACK_SAVEAREA_MODE 
(SAVE_NONLOCAL))
			   / GET_MODE_SIZE (Pmode), 1)
		      + 2 /* Stack pointer and frame pointer.  */
		      + 1 /* Slop for mips.  */
		      - 1);

OK to apply ?

Cheers
   Nick

-------------- next part --------------
A non-text attachment was scrubbed...
Name: except.c.patch.4
Type: application/x-troff-man
Size: 4663 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20140514/40fddc9d/attachment.4>


More information about the Gcc-patches mailing list