[PATCH Ping v2] Extend -fstack-protector-strong to cover calls with return slot

Jeff Law law@redhat.com
Fri May 9 06:26:00 GMT 2014


On 05/05/14 05:58, Florian Weimer wrote:
> On 02/03/2014 10:05 AM, Florian Weimer wrote:
>> On 01/17/2014 11:26 AM, Florian Weimer wrote:
>>> On 01/08/2014 03:57 PM, Florian Weimer wrote:
>>>
>>>> What about the attached version?  It still does not exactly match your
>>>> original suggestion because gimple_call_lhs (stmt) can be NULL_TREE if
>>>> the result is ignored and this case needs instrumentation, as you
>>>> explained, so I use the function return type in the aggregate_value_p
>>>> check.
>>>>
>>>> Testing is still under way, but looks good so far.  I'm bootstrapping
>>>> with BOOT_CFLAGS="-O2 -g -fstack-protector-strong" with Ada enabled,
>>>> for
>>>> additional coverage.
>>>
>>> Testing passed without new regressions.  Is this okay for trunk?
>>
>> Ping?  Thanks.
>
> Now that 4.9 is released, I'd like to propose again this fix for inclusion:
>
> <http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00374.html>
OK for the trunk.

jeff



More information about the Gcc-patches mailing list