Changing INT to SI mode

Richard Biener richard.guenther@gmail.com
Mon Mar 31 08:21:00 GMT 2014


On Fri, Mar 28, 2014 at 8:18 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Mar 28, 2014, at 6:23 AM, K_s, Vishnu <Vishnu.K_s@atmel.com> wrote:
>> Test pr59940.c is failing for AVR target because the test assumes the size
>> of int as 32 bit and test expect to generate warnings for overflow and
>> conversion while assigning 36-bit and 32 bit value respectively to variable si.
>> Following patch define a 32 bit type with SI mode and use it.
>>
>> 2014-03-28  Vishnu K S <Vishnu.k_s@atmel.com >
>>
>>       * gcc/testsuite/gcc.dg/pr59940.c: Using 32-bit SI mode instead of int
>
> [ see previous note ]
>
> Ok.
>
>
> I checked this in for you, and formatted the ChangeLog slightly better.  Two spaces after the name, no space before the >, no gcc/testsuite in the log, end sentence with a period, add name of what was changed (si in this case).

IMHO instead of mode(SI) you should use int32_t (or __INT32_TYPE__
conveniently defined by gcc).

Richard.

> +2014-03-28  Vishnu K S  <Vishnu.k_s@atmel.com>
> +
> +       * gcc.dg/pr59940.c (si): Use 32-bit SI mode instead of int.



More information about the Gcc-patches mailing list